Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The styles page in the site editor #59675

Closed
unprintedch opened this issue Mar 7, 2024 · 6 comments
Closed

The styles page in the site editor #59675

unprintedch opened this issue Mar 7, 2024 · 6 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@unprintedch
Copy link

What problem does this address?

It is not clear enough when you are editing local VS global style settings
we need a more direct access "theme" related settings to setup the bases of a new website.

What is your proposed solution?

When you enter the editor and then style you are offered pre-defined setting.
Could we have the setting that are present later on
Capture d’écran 2024-03-07 à 15 17 51
Like:
DEFAULT STYLE

  • Site logo and favicon
  • Typography (police, weight, size and colors)
  • Color palette
  • Spacing (basic default)
  • Forms?
    Per block global settings >
    See capture below
Capture d’écran 2024-03-07 à 18 38 07

I thinks it will also solve the site icon/favicon problem.

@unprintedch unprintedch added the [Type] Enhancement A suggestion for improvement. label Mar 7, 2024
@Marc-pi
Copy link

Marc-pi commented Mar 7, 2024

yep, far better !

@huubl
Copy link
Contributor

huubl commented Mar 7, 2024

+1
In addition, I propose that when modifying Global Styles, the relevant elements from the Style Book should be the default to visualize the user changes. But also have the option to select a specific page for previewing these changes. See my (outdated) issue:
#49187

@unprintedch
Copy link
Author

unprintedch commented Mar 8, 2024

Select the preview page is a good idea, so we could make some "test page" with the relevant paterns and block.
I also would like that the fonts/color/spacing options sticks on the left.
We could so define 2 things. The global settings are always left and on a dark bg and the local changes are always right with light bg.

@jordesign jordesign added the General Interface Parts of the UI which don't fall neatly under other labels. label Mar 12, 2024
@scruffian
Copy link
Contributor

I like this idea, and it fits well with the direction in #53483. I think there are still a lot of uncertainties around how we'll surface this level of detail inside the Site View, which are being explored in the Data Views project (for example this #59659).

I think we should wait to see what the outcome of those explorations are before we commit to a path forward here.

@annezazu
Copy link
Contributor

Thanks so much for opening this and showing what you'd like to see visually. It's always helpful to see what folks find useful. To prevent confusion and duplicated discussion, I'm going to close this issue out though and encourage you all to continue the discussion on #53483. This is where work is more actively being discussed and solutions are being considered.

@annezazu
Copy link
Contributor

Please let me know if you would like to post and I'll delete my comment but, for now, to ensure nothing is lost, I've taken your proposed solution and feedback to that current issue so it's more readily available for consideration <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
6 participants