Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibit usage of "G(g)utenberg_" prefixed functions, classes, and objects in ./packages/block-library PHP code. #54745

Closed
anton-vlasenko opened this issue Sep 22, 2023 · 1 comment · Fixed by #57738
Closed

Prohibit usage of "G(g)utenberg_" prefixed functions, classes, and objects in ./packages/block-library PHP code. #54745

anton-vlasenko opened this issue Sep 22, 2023 · 1 comment · Fixed by #57738
Assignees
@anton-vlasenko
Labels
[Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.

Comments

@anton-vlasenko
Copy link
Contributor

anton-vlasenko commented Sep 22, 2023 •
edited
Loading

What Problem Does This Address?

Calling functions prefixed with G(g)utenberg_ (and potentially instantiating objects of classes prefixed with Gutenberg_, as well as defining classes prefixed with Gutenberg_) should not be allowed in ./packages/block-library PHP code.

What Is Your Proposed Solution?

Either existing linting rules should be reused, or new ones should be written to address this issue.
@anton-vlasenko anton-vlasenko self-assigned this Sep 22, 2023
@anton-vlasenko anton-vlasenko added the [Type] Code Quality Issues or PRs that relate to code quality label Sep 22, 2023
@anton-vlasenko anton-vlasenko mentioned this issue Sep 22, 2023
Merged
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Package] Block library /packages/block-library labels Sep 24, 2023
@anton-vlasenko
Copy link
Contributor Author

anton-vlasenko commented Dec 5, 2023 •
edited
Loading

I'm working on a PR for this issue.

UPD December 16th: My PR is halfway complete (but needs a lot of polishing), and I'm unable to dedicate more time to it at the moment.
Considering the upcoming holidays, the pull request will likely be submitted at the beginning of January.
@anton-vlasenko anton-vlasenko mentioned this issue Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
2 participants
@jordesign @anton-vlasenko