Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSS Units Value 4 ('svh', 'lvh', 'dvh', 'svw', 'lvw', 'dvw', ...) #52441

Closed
ghost opened this issue Jul 7, 2023 · 2 comments · Fixed by #54415
Closed

Add support for CSS Units Value 4 ('svh', 'lvh', 'dvh', 'svw', 'lvw', 'dvw', ...) #52441

ghost opened this issue Jul 7, 2023 · 2 comments · Fixed by #54415
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@ghost
Copy link

ghost commented Jul 7, 2023

What problem does this address?

Hey. I added this in theme.json:

"spacing": {
	"units": [
		"px",
		"%",
		"em",
		"rem",
		"vh",
		"vw",
		"dvh",
		"dvw",
		"vb",
		"vw"
	]
},

When editing a block, only these are available:

SCREENSHOT-1

As you can see, in this example, "dvh", "dvw", "vb" and "vw" are missing.

What is your proposed solution?

I pleasantly ask you to: Recognize the missing CSS Relative Units.
List: https://www.w3.org/TR/css-values-4/#viewport-relative-units
More info: https://www.terluinwebdesign.nl/en/css/incoming-20-new-css-viewport-units-svh-lvh-dvh-svw-lvw-dvw/
More info: https://caniuse.com/viewport-unit-variants

Please consider a backport to WP 6.3.

@Ren2049
Copy link

Ren2049 commented Jul 8, 2023

This addition would be really important for designers, more context: https://css-tricks.com/the-large-small-and-dynamic-viewports/

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Jul 10, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 13, 2023
@aristath
Copy link
Member

PR is now available in #54415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
3 participants