Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min Height block support follow-up tasks #45501

Open
4 of 6 tasks
andrewserong opened this issue Nov 3, 2022 · 3 comments
Open
4 of 6 tasks

Min Height block support follow-up tasks #45501

andrewserong opened this issue Nov 3, 2022 · 3 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Nov 3, 2022

As of #45300, a minimally viable version of the minimum height block support has been introduced, which opts both the Group and Post Content blocks in to a minimum height control in the dimensions panel, which is hidden by default.

There were some good suggestions and ideas flagged both on that PR and some related issues. This issue is to group together some of those tasks and notes so that they don't get missed.

Tasks

Issues to (potentially) close out once these tasks are done

@andrewserong andrewserong added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Nov 3, 2022
@poof86
Copy link

poof86 commented Nov 11, 2022

Will minHeight also be added to the Column Block?
I'm asking because the Column Block has the options for vertical alignment.

Maybe we could include vertical alignment to the Group Block also?
It would go well with this minHeight setting.

Sidenote:
I was hoping to get this minHeight feature in my Gutenberg installation before the next milestone releases.
But I don't know how to get this into my current project. If somebody could help me in the right direction how to do this that would be awesome.

I presume I pull the current trunk, because this feature is already merged.
Next I "npm run build" the project to get my release right? (probably need to do a npm install first?)
Or is there a compile git command that can do this for me on the GitHub server?

Thank you, sorry for going off topic

@cbirdsong
Copy link

cbirdsong commented Mar 6, 2023

@andrewserong
Copy link
Contributor Author

Oh, that's a great idea @cbirdsong! I've added that to the list of tasks in the issue description and added the needs design feedback label to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement.
3 participants