Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: undo/redo causes screen to jump #39000

Closed
annezazu opened this issue Feb 22, 2022 · 4 comments
Closed

Site Editor: undo/redo causes screen to jump #39000

annezazu opened this issue Feb 22, 2022 · 4 comments
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Feb 22, 2022

Description

Undo/redo in the Site editor causes the editor to jump up in some situations when content is below the fold. This was found as part of the FSE Outreach Program's All Things Media exploration.

Step-by-step reproduction instructions

  1. Open site editor.
  2. Add a header and a paragraph block below the fold above the footer.
  3. Make minor changes (bold, italics, etc).
  4. Hit undo and notice the editor jumps up higher each time you do.

Screenshots, screen recording, code snippet

Here's a video from me replicating the problem:
https://user-images.githubusercontent.com/26996883/155221788-91743f30-736c-45ce-98e4-18c65722792d.mov

Here's the originally reported video demonstrating the issue: https://app.koofr.net/links/481d3053-4fd1-4756-60ef-5db5b25d0ed2

I tried to recreate the undo/redo issue on php 7.4, 8.0 and 8.1 with 5.9
8.1(peach background) 00:02
8.0(blue ) 00:40
7.4(green) 01:15
Make sure the header block is active.
Have content longer than the fold.

When GB inactive
On 8.1 : Inconsistancy undo/redo
On 8.0 : Block jump when applying undo/redo
7.4 : Same as 8.0

With GB active
8.1 : No more issue with undo/redo
8.0 and 7.4 Same issues, when GB is inactive

Environment info

  • WordPress 5.9.
  • Happens with Gutenberg deactivated and with Gutenberg 12.6 activated.
  • MacOS
  • Chrome

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] History History, undo, redo, revisions, autosave. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 22, 2022
@annezazu annezazu added this to 📥 To do in WordPress 5.9.x via automation Feb 22, 2022
@quakeboy
Copy link

quakeboy commented Mar 17, 2022

This is ruining the writing experience. Is there a way you guys could add test cases to avoid such editor bugs?

@glendaviesnz
Copy link
Contributor

I am not able to replicate this on trunk, are you still seeing it @annezazu ?

undo-jump.mp4
@annezazu
Copy link
Contributor Author

It seems improved with 15.8.1!

tiny.jump.mov

If you can't replicate with trunk though, I'm curious what improved this experience so we can ensure it sticks :)

@annezazu
Copy link
Contributor Author

Closing this out as I can no longer replicate with 16.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
3 participants