Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: multi selecting blocks causes editor to jump to top #38803

Closed
annezazu opened this issue Feb 15, 2022 · 8 comments
Closed

Site Editor: multi selecting blocks causes editor to jump to top #38803

annezazu opened this issue Feb 15, 2022 · 8 comments
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

Description

This was found as part of the FSE Outreach Program's All Things Media Exploration:

Selecting few blocks below the fold takes the editor to the top.

This is quite disruptive and jarring, especially if you're simply trying to move a few blocks around. cc @andrewserong since I can see you're working on implementing multi select for List View: #38314

Of note: this only happens when using 5.9 alone. It does not happen with Gutenberg 12.5.4. I checked for PRs related to multi select but couldn't find anything recent that was relevant (this was the only thing I could loosely find that might have been related for 5.9 #37595). Either way though, it works in the current GB version so whatever fixed it needs to be backported.

Step-by-step reproduction instructions

  1. Open the site editor
  2. Add content so there is some below the editor view and you have to scroll down.
  3. Try to select multiple blocks below the top of the editor.
  4. Notice the editor jumps to the top.

Screenshots, screen recording, code snippet

multi.select.mov

Environment info

  • WordPress 5.9
  • TT2
  • Chrome
  • MacOS
  • Happens without GB 12.5.4

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Block Multi Selection The ability to select and manipulate multiple blocks Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 15, 2022
@annezazu annezazu added this to 📥 To do in WordPress 5.9.x via automation Feb 15, 2022
@andrewserong
Copy link
Contributor

Thanks for the ping, Anne! Unfortunately, from a quick skim through Gutenberg PRs, I couldn't find any recent changes that would obviously affect things, either. But, I also couldn't replicate the issue in 5.9 with Gutenberg deactivated 🤔... I'm testing in WP 5.9, Chrome, MacOS:

Kapture.2022-02-15.at.17.23.34.mp4

I wonder if there's anything else at play (or that I'm missing in my testing environment)?

@annezazu
Copy link
Contributor Author

How strange! I pulled up a different test site (without Gutenberg) and could still replicate :/

@fwazeter
Copy link
Member

Bizarre bug, I couldn't replicate it either in chrome or on Firefox (albeit on Ubuntu).

@alanjacobmathew
Copy link
Contributor

Retested on Windows 10 with Brave, Firefox and Chromium

When PHP 8.0 was used I was able to replicate it in Chromium and Brave, but not in Firefox
When 8.1 version was used everything was working as expected in all 3 browsers.

In the gif below, the red background is version 8.0 and the white is 8.1

8 0 vs 8 1 version

@costdev
Copy link
Contributor

costdev commented Feb 22, 2022

OS: Windows 10
PHP: 7.4

Issue reproduced

  • Brave | WordPress 5.9 | TT2 | Gutenberg not active
  • Brave | WordPress 5.9 | TT1 Blocks | Gutenberg not active

Issue not reproduced

  • Chrome | WordPress 5.9 | Gutenberg not active
  • Brave | WordPress 5.9 | Gutenberg 12.2.0+ active
  • Brave | WordPress 5.8.3 | Gutenberg 12.0.1 active

I haven't tracked down when this was introduced or fixed.

@Mamaduka Mamaduka removed the Backport to WP Minor Release Pull request that needs to be backported to a WordPress minor release label Nov 7, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Nov 7, 2022

I've removed "Backport to WP Minor Release"; we only use this label for PRs.

@youknowriad
Copy link
Contributor

I'm not able to reproduce this. Can anyone confirm?

@annezazu
Copy link
Contributor Author

Testing with 6.2 beta 3, I cannot replicate. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
7 participants