Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve duotone popover experience to keep popover open #38797

Closed
annezazu opened this issue Feb 15, 2022 · 2 comments
Closed

Improve duotone popover experience to keep popover open #38797

annezazu opened this issue Feb 15, 2022 · 2 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

In the latest FSE Outreach Program's All Things Media exploration the following feedback was shared:

When working with Duotone, applying the first filter takes back the user to the editor which makes it more troublesome to modify the style, while when applying the following filters the settings control still visible on the frontend so the user can preview the style before coming to the conclusion. It’ll be better if the settings control stays visible when applying the very first effect.

Here's a video of the current experience:

duotone.mov

What is your proposed solution?

Keep the pop over open throughout rather than having it go away after first applying a filter.

Just in case it's related, here's a prior issue #29746 (comment)

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Feb 15, 2022
@richtabor
Copy link
Member

Not sure if it's related, but we do have a bit of interface jump when applying a filter.

CleanShot.2023-01-20.at.11.42.09.mp4
@jeryj
Copy link
Contributor

jeryj commented Mar 22, 2023

Unintentionally fixed by #48401.

These lines were causing the popover to close when there were no duotone styles. It's unclear to me why it was closing after the first selection, but I have confirmed the return <BlockListBlock { ...props } />; line was causing this behavior.

@jeryj jeryj closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
3 participants