Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to turn off double confirmation multi-entity saving screen #38714

Open
annezazu opened this issue Feb 10, 2022 · 6 comments
Open
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Saving Related to saving functionality [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

This came up in the latest FSE outreach program's All Things Media exploration:

I kept wanting to be able to turn off the double confirmation in the Site Editor. It was like, yes, I’m aware I probably edited multiple parts, I know what I’m doing and I want the option to turn that off if I want. I went looking for the Preferences panel instinctively despite knowing that there wasn’t one there yet.

In the post editor, there's this option but we like the same one in the site editor:

image (17)

What is your proposed solution?

This likely could be seen as part of site editing UI parity: #21245.

The only concerns on my mind are around what else might be added to this saving flow. For example, some items like saving edits as a new template are being explored before the multi entity step ideally: #27851 whereas others like draft/scheduling changes are being explored design wise in the multi entity flow: #29575 Just something to clearly communicate and be aware of rather than a blocker :)

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. [Feature] History History, undo, redo, revisions, autosave. [Feature] Full Site Editing labels Feb 10, 2022
@annezazu
Copy link
Contributor Author

This also previously came up in the second call for testing:

I can understand why there is a 2-step process here, but every time I clicked “Update Design” it intuitively felt like I shouldn’t have to then click a “Save” button as well.

@jasmussen
Copy link
Contributor

jasmussen commented Feb 14, 2022

As parity with the ability to disable the same panel in the post editor, and on by default, sure! I wonder if we should rephrase the option ever so slightly to make it more clear that you can push global changes with a single click? A stab at new help-text:

Review edits and changes before making them all public

☝️ could be more elegant. Any thoughts?

@annezazu
Copy link
Contributor Author

I really like that phrasing!

@carolinan
Copy link
Contributor

This is a duplicate of #32386
and it is becoming an unwelcome distraction the more I work with the site editor.
But since this issue has some more details, I will close 32386.

@annezazu
Copy link
Contributor Author

annezazu commented Apr 4, 2022

Apologies for missing that original issue! I very much did try to search but managed to miss it 🤦🏼 Thanks for connecting the dots.

@annezazu annezazu added the [Feature] Saving Related to saving functionality label Apr 4, 2022
@annezazu
Copy link
Contributor Author

Feedback came up related to this during the FSE Outreach Program's Build a Block Theme exploration:

When saving I get the “Are you ready to save?” screen to check which entities should be saved, even if only one entity (“Global Styles”) needs to be saved. But I guess that makes sense, since accidently publishing styles which are not perfect yet, is bad 😅

Worth considering as we think about the double confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. [Feature] Saving Related to saving functionality [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") General Interface Parts of the UI which don't fall neatly under other labels. [Type] Enhancement A suggestion for improvement.
3 participants