Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery block refactor: Replacing a captioned image with one without caption retains the caption #34862

Open
andrewserong opened this issue Sep 16, 2021 · 1 comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Discussion For issues that are high-level and not yet ready to implement.

Comments

@andrewserong
Copy link
Contributor

During testing of the gallery refactor it was reported that if you replace an image with a caption with an image without a caption, the caption on the image is retained, which might not be the expected behaviour.

I could replicate this, and I had a couple of thoughts:

  1. As a user I might have the right caption in mind, but be trying out a few different possible images. In this case, I'd want the caption to be retained (so the current behaviour could be expected).
  2. Or, as a user, I might be trying to replace the image altogether so the retained caption could be unexpected and feel like something's broken.

I think I'm leaning toward thinking that we should default to the second expectation. Here's a screengrab of the current behaviour, where the caption is retained:

Kapture 2021-09-16 at 14 57 54

@andrewserong andrewserong added [Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Discussion For issues that are high-level and not yet ready to implement. labels Sep 16, 2021
@andrewserong andrewserong added this to Follow up after merge in Gallery block improvements Sep 16, 2021
@andrewserong andrewserong moved this from Follow up after merge to Backlog in Gallery block improvements Sep 16, 2021
@annezazu
Copy link
Contributor

annezazu commented Feb 7, 2022

This came up as part of the FSE Outreach Program's All Things Media exploration:

It would be nice that when an image is changed in a gallery that the previous caption entered through the block editor and not the media editor would also go away. Currently, the old captions will still show after the image has been swapped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Discussion For issues that are high-level and not yet ready to implement.
2 participants