Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: Color options could be grouped for better consistency #30719

Closed
carolinan opened this issue Apr 12, 2021 · 5 comments
Closed

Feedback: Color options could be grouped for better consistency #30719

carolinan opened this issue Apr 12, 2021 · 5 comments
Labels
[Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable

Comments

@carolinan
Copy link
Contributor

What problem does this address?

This was brought up during a contributor day at Yoast on April 9;
When a block has a link color option, the color options in the block settings sidebar are displayed in the following order:

Text color
Background color
Link color

And when a block has a link color option but no text color option, the order is
Background color
Link color

What is your proposed solution?

Text color and link color options should be grouped together, they both add color to the text.

@carolinan carolinan added the [Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable label Apr 12, 2021
@annezazu
Copy link
Contributor

@carolinan can you clarify a bit here what you want to see? Do you want a different order of color options? I'm not quite following this issue or the problem.

@carolinan
Copy link
Contributor Author

carolinan commented Apr 18, 2021

Yes, I interpreted it as the user wondering why the order of the color options is different for different blocks.

A more consistent order would be:
Background color
Text color
Link color

When there is no link color:
Background color
Text color

When there is a link color but no text color:
Background color
Link color

@mtias
Copy link
Member

mtias commented Dec 17, 2021

I think this is more clear with the latest implementation:

image

@mtias
Copy link
Member

mtias commented Dec 17, 2021

Though inconsistent capitalization, and "color" feels redundant :)

@jorgefilipecosta
Copy link
Member

Though inconsistent capitalization, and "color" feels redundant :)

Fix proposed at #37493.

@mtias mtias closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Feedback Issues that relate purely to feedback on a feature that isn't necessarily actionable
4 participants