Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block refactor: rotating image forces all images on row to same aspect ratio #30362

Open
glendaviesnz opened this issue Mar 30, 2021 · 2 comments
Open

Gallery block refactor: rotating image forces all images on row to same aspect ratio #30362

glendaviesnz opened this issue Mar 30, 2021 · 2 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
Projects
Gallery block improvements

Comments

@glendaviesnz
Copy link
Contributor

If one image is rotated 90 degrees it is forced to portrait aspect ratio, which forces all images in same row to same aspect ratio which can force images to stretch:

rotate
@glendaviesnz glendaviesnz added [Type] Bug An existing feature does not function as intended [Block] Gallery Affects the Gallery Block - used to display groups of images labels Mar 30, 2021
@glendaviesnz glendaviesnz added this to Known issues in Gallery block improvements Mar 30, 2021
@glendaviesnz
Copy link
Contributor Author

Any fix for this will most likely require a rethink of how the grid layout works for the gallery so deferring until after the first release of the gallery block refactor.
@glendaviesnz glendaviesnz moved this from Known issues to fix for Release 1.0 to Review After Release 1.0 in Gallery block improvements Apr 23, 2021
@glendaviesnz glendaviesnz moved this from Backlog to Follow up after merge in Gallery block improvements Sep 9, 2021
@glendaviesnz glendaviesnz moved this from For 5.9 Release to Backlog in Gallery block improvements Sep 16, 2021
@annezazu
Copy link
Contributor

Passing along some feedback that came in through the FSE Outreach Program's All Things Media exploration:

Rotate was..weird? One of the images I had was inherently a very large image, and it would go to its full size when I tried to rotate. I expected it stay the same size it was in the gallery, and it made the experience kind of awkward.
@jordesign jordesign mentioned this issue Sep 8, 2023
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
2 participants
@glendaviesnz @annezazu