Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSE] Enable keyboard shortcut for saving site editor changes #29642

Closed
annezazu opened this issue Mar 8, 2021 · 1 comment · Fixed by #36138
Closed

[FSE] Enable keyboard shortcut for saving site editor changes #29642

annezazu opened this issue Mar 8, 2021 · 1 comment · Fixed by #36138
Assignees
@Mamaduka
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Keyboard Shortcuts /packages/keyboard-shortcuts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
WordPress 5.9 Must-Haves

Comments

@annezazu
Copy link
Contributor

annezazu commented Mar 8, 2021

What problem does this address?

As part of the second round of testing for the FSE Outreach Program, the following feedback was given:

When editing, I expect CMD/CTRL + S to save my work. This works in a post/page editing experience. On OS X + Chrome, this prompts me to save the webpage.

Similar to this issue around saving autosaving #29577, this is likely a bit complex due to the multi-entity saving process but I imagine is something users are used to having in place.

What is your proposed solution?

Perhaps using this shortcut pops open the saving process for example rather than saving everything.
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [a11y] Keyboard & Focus [Package] Keyboard Shortcuts /packages/keyboard-shortcuts [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 8, 2021
@carolinan
Copy link
Contributor

The need to add this missing short cut was also brought up during user testing on April 9.
@carolinan carolinan added the [Feature] Template Editing Mode Related to the template editor available in the Block Editor label May 7, 2021
@annezazu annezazu mentioned this issue Oct 28, 2021
Closed
@annezazu annezazu added this to 📥 To do in WordPress 5.9 Must-Haves via automation Oct 28, 2021
@Mamaduka Mamaduka self-assigned this Oct 29, 2021
@noisysocks noisysocks moved this from 📥 To do to 🏗️ In progress in WordPress 5.9 Must-Haves Nov 1, 2021
@Mamaduka Mamaduka mentioned this issue Nov 2, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 2, 2021
WordPress 5.9 Must-Haves automation moved this from 🏗️ In progress to ✅ Done Nov 2, 2021
@priethor priethor added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Keyboard Shortcuts /packages/keyboard-shortcuts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
4 participants
@Mamaduka @carolinan @annezazu @priethor