Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed blocks: Need resize handles #14805

Open
neobabis opened this issue Apr 3, 2019 · 3 comments
Open

Embed blocks: Need resize handles #14805

neobabis opened this issue Apr 3, 2019 · 3 comments
Labels
[Block] Embed Affects the Embed Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@neobabis
Copy link

neobabis commented Apr 3, 2019

Enhancement request

I think that is necessary to have the ability to decrease/increase the size of an embed block (e.g. Facebook block) like the Image block.

ResizeImageBlock

@swissspidy swissspidy added [Block] Embed Affects the Embed Block [Type] Enhancement A suggestion for improvement. labels Apr 5, 2019
@mapk
Copy link
Contributor

mapk commented Apr 24, 2019

Thanks for this suggestion, @neobabis! We talked it through in today's Editor chat in slack.

Looks like we can push this forward with a single width handle for resizing. We'll need to maintain the aspect ratio of the video as we do for images. props to @jasmussen @notnownikki

@karmatosed brought up that we should also test this with a variety of themes.

@mapk mapk added the Needs Dev Ready for, and needs developer efforts label Apr 24, 2019
@neobabis
Copy link
Author

A problem (just a simple example):

Full width page > Facebook video - portrait orientation
You have only one solution: You should add css class to decrease the size. And of course one class per size.

On the other hand, for an image block we don't need css classes for different sizes because we have the "resizing ability".

@annezazu
Copy link
Contributor

As part of the FSE Outreach Program's third call for testing, this came up as a pain point. Currently, there's no way to resize what's shown and the experience breaks the WYSIWYG experience of site building as a result. Here's what one sees in the back end vs front end:

Backend:

Screen Shot 2021-03-12 at 4 13 31 PM

Frontend:

Screen Shot 2021-03-12 at 4 11 04 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Embed Affects the Embed Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
4 participants