Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify pathway card hover style with themes, plugins #2628

Closed
jasmussen opened this issue Jul 5, 2024 · 4 comments
Closed

Unify pathway card hover style with themes, plugins #2628

jasmussen opened this issue Jul 5, 2024 · 4 comments
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Dev] Needs Design

Comments

@jasmussen
Copy link

It’s nice that there’s a big gray hover style on these:

Image

However we settled on a charcoal (almost black) border color on hover, instead of a background color change, for Plugins and Themes, it would probably be best to do the same here. That also avoids the discrepancy where the pathways cards have a hover style, but the course cards do not.

@adamwoodnz adamwoodnz added the [Component] Learn Theme Website development issues related to the Learn theme. label Jul 8, 2024
@adamwoodnz adamwoodnz added this to the Learning Pathways launch milestone Jul 8, 2024
@ryelle ryelle self-assigned this Jul 11, 2024
@ryelle
Copy link
Contributor

ryelle commented Jul 11, 2024

@jasmussen This appears to be inheriting this style from the parent theme, and the same style is used on (at least) Forums & Developer Resources landing pages. Should it be updated everywhere?

Screenshot 2024-07-11 at 5 18 43 PM Screenshot 2024-07-11 at 5 19 54 PM
@jasmussen
Copy link
Author

Excellent catch. I'm conflicted, the gray hover style is quite nice in most of those place. Perhaps we leave this as is. @WordPress/meta-design

@ryelle ryelle removed their assignment Jul 17, 2024
@fcoveram
Copy link

The hover style of cards and other similar elements placed in grids is a big topic. I aim for consistency as well, but in this case, I would keep it as is and address the issue once we're done with the style updates of the site.

@adamwoodnz
Copy link
Contributor

Closing, as it seems there is general agreement that consistency with other sites in the 'Learn' category is most important here, and therefore we should leave this as is for now. We can address later site wide if necessary.

@adamwoodnz adamwoodnz closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Dev] Needs Design
4 participants