Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Functionality #2263

Closed
Tracked by #1984
jonathanbossenger opened this issue Feb 26, 2024 · 9 comments
Closed
Tracked by #1984

Block Functionality #2263

jonathanbossenger opened this issue Feb 26, 2024 · 9 comments
Assignees
Labels
[Content] Published Marks closed issues as content that was actually published.

Comments

@jonathanbossenger
Copy link
Collaborator

jonathanbossenger commented Feb 26, 2024

Details

  • Content type (Online Workshop, Lesson, Course, Tutorial, or Lesson Plan):
  • Content title:
  • Topic description:
  • Audience (User, Developer, Designer, Contributor, etc.):
  • Experience Level (Beginner, Intermediate, Advanced, Any):

Learning Objectives

  • Describe how the Edit component and save function are at the core of the block functionality
  • Implement the block's functionality in the editor by updating the Edit component
  • Use the block's save function to render the output to be saved

Related Resources and Other Notes

Automation Code

@jonathanbossenger
Copy link
Collaborator Author

//lesson

Copy link
Contributor

github-actions bot commented Feb 26, 2024

Lesson Development Checklist

  • Gather any relevant links to Support, Docs, or related material
  • Description and Objectives finalized
  • Lesson created and announced to the team for review
  • Lesson reviewed
  • Lesson video submitted and published to WPTV
  • Lesson created on Learn.WordPress.org
  • Lesson video published to YouTube
  • Lesson on Learn.WordPress.org updated with YouTube video
  • Lesson published to Learn.WordPress.org
@jonathanbossenger
Copy link
Collaborator Author

04.Block.Functionality.mp4

Video for review

@jonathanbossenger jonathanbossenger self-assigned this Mar 3, 2024
@ironnysh
Copy link

ironnysh commented Mar 20, 2024

Tutorial/Lessons Review Checklist

  • Learning outcomes/objectives are clear.
  • Technical concepts introduced in the content are accurate.
  • The speed of demonstrations are easy to follow.
  • The narration audio matches what is shown visually.
  • Spelling and grammar are correct.
  • Sound quality is consistent throughout the video.
  • Brand Usage Guidelines and Promotional Guidelines are being followed.
  • Media assets are all in the public domain (CC0).

Great tutorial, @jonathanbossenger--informative and easy to understand.

I had difficulty watching the video (I tried multiple broswers). Since this happened to other people with a few other videos, it might be helpful to add an alternative link.

Other than that, there were a bunch of audio problems:

  • At 3:10 and 3:14 there are repetitions "For now, update the component to return...".
  • This happens again at 4:01, with "you probably don't want to hardcode...".
  • There's a sound issue at 4:09 and again at 5:30.
  • There's a silence in 6:22-6:31, and then you start with a variation of the same sentence. This happens again a bit later and only starts "clean" at 6:55.
  • There are a few "false starts" again at 7:35 until 7:46, and a few seconds later it happens again with another sentence.
  • and again at 8:29 and at 9:18-9:19 :-)
  • It seems like there's an outro missing
@jonathanbossenger
Copy link
Collaborator Author

04.Block.Functionality.mp4

Thanks for the review @ironnysh. It seems that some of my edits either didn't save, or exported incorrectly. So I've reexported the video, and the bugs should now be fixed.

I had difficulty watching the video (I tried multiple broswers). Since this happened to other people with a few other videos, it might be helpful to add an alternative link.

It was reported to me that some of the other videos were running at a very low framerate. This seems to also have been fixed, but let me know if you see it with newer videos.

@jonathanbossenger
Copy link
Collaborator Author

@bsanevans bsanevans added the [Content] Published Marks closed issues as content that was actually published. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Content] Published Marks closed issues as content that was actually published.
3 participants