Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework for storing revisions of Post Meta #1190

Open
abhansnuk opened this issue Oct 14, 2023 · 12 comments
Open

Framework for storing revisions of Post Meta #1190

abhansnuk opened this issue Oct 14, 2023 · 12 comments
Labels
6.4 Changes in 6.4 release [Status] To do Issue marked as Todo
Milestone

Comments

@abhansnuk
Copy link
Collaborator

Trac Ticket: https://core.trac.wordpress.org/ticket/20564

Owner: adamsilverstein

@github-actions
Copy link

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@abhansnuk
Copy link
Collaborator Author

Comment on trac ticket to see if this is for the Miscellaneous dev note and if there is a draft.

@shabnam611 shabnam611 added the 6.4 Changes in 6.4 release label Oct 14, 2023
@shabnam611 shabnam611 added this to the 6.4 milestone Oct 14, 2023
@adamsilverstein
Copy link
Member

No draft yet, I will work on a draft today and share that here.

@adamsilverstein
Copy link
Member

adamsilverstein commented Oct 16, 2023

Here is a draft of the dev note for 20564: https://docs.google.com/document/d/1ctRkft6qFCHAS3HmJGsBvsWosE7LrYV5mLho0breB28/edit?usp=sharing - Ideally I would like to get some feedback from other contributors before posting to make sure I got it right, made things clear and didn't miss anything.

@nalininsbs
Copy link

Thank you @adamsilverstein .

@zzap zzap added the [Status] To do Issue marked as Todo label Oct 17, 2023
@nalininsbs
Copy link

nalininsbs commented Oct 19, 2023

Link to follow up on technical feedback.

Update: link to this updated, and also shared in documentation.

@abhansnuk
Copy link
Collaborator Author

abhansnuk commented Oct 21, 2023

Technical review on Google doc thanks to Jorbin and westonruter. Comments / discussion back with @adamsilverstein (core slack).

Then second review. If Field Guide published, then add link and remove reference of note to follow.

Field Guide draft has a sentence and text on dev note to follow. Message in release leads to verify publication of FG.

@adamsilverstein
Copy link
Member

I have reviewed Jorbin and Weston's feedback and incorporated their suggestions. The doc is ready for a second review.

@abhansnuk
Copy link
Collaborator Author

abhansnuk commented Oct 23, 2023

@adamsilverstein second review in the google doc has now been completed. Comments on the doc.

Thanks to Weston and Jorbin for responding to the urgent call for the detailed tech review.

Can you please add the dev note to the P2, with short text in the excerpt field too. Please let me know when this is ready to add tags and publish. Thanks so much for all your work on this and the feature.

Update: the Field Guide has been published. We can add this dev note to it as an update. The plugins email will go, I expect, Tuesday. So if this is ready before, we will try to get an update in the FG before that. But recognize this may not be possible.

@adamsilverstein
Copy link
Member

Is it likely that this would be possible in the next two hours and we look to hold the Field Guide for it?

Sure, i will work on that shortly.

@adamsilverstein
Copy link
Member

@abhansnuk - posted a draft here - https://make.wordpress.org/core/wp-admin/post.php?post=109302&action=edit I added the dev-note tag, feel free to add a category / tags, make any final edits and publish. Let me know if you have any questions or remaining tasks for me.

@nalininsbs
Copy link

Thank you @adamsilverstein and @abhansnuk for publishing. Abha added to Field Guide. Do we need to log like for end user with update?
https://make.wordpress.org/core/2023/10/24/framework-for-storing-revisions-of-post-meta-in-6-4/
Thank you @aaronjorbin and @westonruter for technical review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.4 Changes in 6.4 release [Status] To do Issue marked as Todo
5 participants