Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double sanitization in get_term function #1182

Open
abhansnuk opened this issue Oct 13, 2023 · 6 comments
Open

Double sanitization in get_term function #1182

abhansnuk opened this issue Oct 13, 2023 · 6 comments
Labels
6.4 Changes in 6.4 release [Status] To do Issue marked as Todo
Milestone

Comments

@abhansnuk
Copy link
Collaborator

abhansnuk commented Oct 13, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/58329

Reported by and owned by spacedmonkey

Keyword on ticket needs-dev-note

This ticket is likely to be covered by one of the performance dev note clusters.
Note it is not in any of the three dev notes drafts shared by spacedmonkey by 2023/10/23. So check with performance.

This comment by Jonny has a good summary.

@github-actions
Copy link

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@codente
Copy link

codente commented Oct 13, 2023

We've asked for a dev note here:
https://core.trac.wordpress.org/ticket/58329#comment:26

Comment 22 has a good summary it appears
https://core.trac.wordpress.org/ticket/58329#comment:22

@shabnam611 shabnam611 added the 6.4 Changes in 6.4 release label Oct 14, 2023
@shabnam611 shabnam611 added this to the 6.4 milestone Oct 14, 2023
@nalininsbs
Copy link

As certain fields are not available to the docs release group, an additional note providing an overview of performance tickets in the run up to the Field Guide deadline, can be found on this docs sheet: Google sheet to better understand status on the performance labelled tickets. Note performance team is wrangling those tickets for identification, first draft and performance first review.

@zzap zzap added the [Status] To do Issue marked as Todo label Oct 17, 2023
@nalininsbs
Copy link

nalininsbs commented Oct 19, 2023

Copying from Trac update. https://core.trac.wordpress.org/ticket/58329#comment:28

The following has been added to the Field Guide performance section based on the commit message in comment 22. We could not find this changed reference in the other mixed dev notes relating to performance. Please add any future dev note on this to the documentation tracking ticket so it can be updated in the Field Guide too. Thank you.

"Taxonomy: The double sanitization in get_term function has been stopped. This will prevent the unnecessary calls to sanitize_term which was detrimental to performance. #58329."

Discussion also raised
in core-performance channel.

@codente
Copy link

codente commented Oct 19, 2023

Just to be included in FG, no dev note needed. needs-dev-note keyword removed
https://core.trac.wordpress.org/ticket/58329#comment:29

@abhansnuk
Copy link
Collaborator Author

This is in the Field Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.4 Changes in 6.4 release [Status] To do Issue marked as Todo
5 participants