Changeset 58308

Timestamp:

06/03/2024 09:23:48 PM (8 weeks ago)

Author:

costdev

Message:

Upgrade/Install: Don't toggle maintenance mode on translation updates.

The Rollback Auto-Update feature introduced additional maintenance mode toggling.

After installing WordPress in a non-English (US) language, translation updates are performed automatically. As there may be a large number of updates for Core and bundled themes, users will be presented with a maintenance notice upon visiting the newly installed website.

To avoid concerning users that the website has failed to install correctly, this excludes translation updates from triggering the additional maintenance mode toggling.

Follow-up to [58128].

Props benniledl, afragen, rajinsharwar, costdev.
Fixes #61260. See #58281.

File:

• trunk/src/wp-admin/includes/class-wp-automatic-updater.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-automatic-updater.php

@@ -471 +471 @@
          * the scrape to miss a fatal error in the plugin update.
          */
-        $upgrader->maintenance_mode( true );
+        if ( 'translation' !== $type ) {
+            $upgrader->maintenance_mode( true );
+        }
 
         // Boom, this site's about to get a whole new splash of paint!
@@ -496 +498 @@
          * or while files are still being moved.
          */
-        $upgrader->maintenance_mode( true );
+        if ( 'translation' !== $type ) {
+            $upgrader->maintenance_mode( true );
+        }
 
         // If the filesystem is unavailable, false is returned.
@@ -614 +618 @@
 
         // All processes are complete. Allow visitors to browse the site again.
-        $upgrader->maintenance_mode( false );
+        if ( 'translation' !== $type ) {
+            $upgrader->maintenance_mode( false );
+        }
 
         $this->update_results[ $type ][] = (object) array(