Changeset 57867

Timestamp:

03/22/2024 10:05:25 PM (4 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-includes/link-template.php.

Follow-up to [4475], [6365], [8706], [9296], [9318], [14141], [15819], [21364], [27802].

Props aristath, poena, afercia, SergeyBiryukov.
See #60700.

File:

• trunk/src/wp-includes/link-template.php (modified) (10 diffs)

trunk/src/wp-includes/link-template.php

@@ -392 +392 @@
     $post = get_post( $post );
 
-    if ( 'page' === get_option( 'show_on_front' ) && get_option( 'page_on_front' ) == $post->ID ) {
+    if ( 'page' === get_option( 'show_on_front' ) && == $post->ID ) {
         $link = home_url( '/' );
     } else {
@@ -702 +702 @@
         }
 
-        if ( get_default_feed() == $feed ) {
+        if ( get_default_feed() == $feed ) {
             $feed = '';
         }
@@ -764 +764 @@
 
     if ( get_option( 'permalink_structure' ) ) {
-        if ( 'page' === get_option( 'show_on_front' ) && get_option( 'page_on_front' ) == $post_id ) {
+        if ( 'page' === get_option( 'show_on_front' ) && == $post_id ) {
             $url = _get_page_link( $post_id );
         } else {
@@ -778 +778 @@
         } else {
             $url = trailingslashit( $url ) . 'feed';
-            if ( get_default_feed() != $feed ) {
+            if ( get_default_feed() != $feed ) {
                 $url .= "/$feed";
             }
@@ -880 +880 @@
     } else {
         $link = get_author_posts_url( $author_id );
-        if ( get_default_feed() == $feed ) {
+        if ( get_default_feed() == $feed ) {
             $feed_link = 'feed';
         } else {
@@ -963 +963 @@
     } else {
         $link = get_term_link( $term, $term->taxonomy );
-        if ( get_default_feed() == $feed ) {
+        if ( get_default_feed() == $feed ) {
             $feed_link = 'feed';
         } else {
@@ -1375 +1375 @@
         $link  = trailingslashit( $link );
         $link .= 'feed/';
-        if ( $feed != $default_feed ) {
+        if ( $feed != $default_feed ) {
             $link .= "$feed/";
         }
@@ -1738 +1738 @@
     }
 
-    if ( get_current_user_id() == $user->ID ) {
+    if ( get_current_user_id() == $user->ID ) {
         $link = get_edit_profile_url( $user->ID );
     } else {
@@ -3057 +3057 @@
     global $wp_rewrite;
 
-    $pagenum = (int) $pagenum;
+    $pagenum  = (int) $pagenum;
+    $max_page = (int) $max_page;
 
     $result = get_permalink();
 
     if ( 'newest' === get_option( 'default_comments_page' ) ) {
-        if ( $pagenum != $max_page ) {
+        if ( $pagenum != $max_page ) {
             if ( $wp_rewrite->using_permalinks() ) {
                 $result = user_trailingslashit( trailingslashit( $result ) . $wp_rewrite->comments_pagination_base . '-' . $pagenum, 'commentpaged' );
@@ -4155 +4156 @@
         $post_type = get_post_type_object( $post->post_type );
 
-        if ( 'page' === $post->post_type && get_option( 'page_on_front' ) == $post->ID && 'page' === get_option( 'show_on_front' ) ) {
+        if ( 'page' === $post->post_type
+            && 'page' === get_option( 'show_on_front' ) && (int) get_option( 'page_on_front' ) === $post->ID
+        ) {
             $shortlink = home_url( '/' );
         } elseif ( $post_type && $post_type->public ) {