Changeset 57656

Timestamp:

02/19/2024 03:05:46 PM (5 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in WP_REST_Navigation_Fallback_Controller tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [56052].

See #59655.

File:

• trunk/tests/phpunit/tests/rest-api/rest-navigation-fallback-controller.php (modified) (5 diffs)

trunk/tests/phpunit/tests/rest-api/rest-navigation-fallback-controller.php

@@ -62 +62 @@
         $data     = $response->get_data();
 
-        $this->assertEquals( 403, $response->get_status(), 'Response should indicate user does not have permission.' );
-
-        $this->assertEquals( 'rest_cannot_create', $data['code'], 'Response should indicate user cannot create.' );
-
-        $this->assertEquals( 'Sorry, you are not allowed to create Navigation Menus as this user.', $data['message'], 'Response should indicate failed request status.' );
+        $this->assert( 403, $response->get_status(), 'Response should indicate user does not have permission.' );
+
+        $this->assert( 'rest_cannot_create', $data['code'], 'Response should indicate user cannot create.' );
+
+        $this->assert( 'Sorry, you are not allowed to create Navigation Menus as this user.', $data['message'], 'Response should indicate failed request status.' );
     }
 
@@ -81 +81 @@
         $data     = $response->get_data();
 
-        $this->assertEquals( 200, $response->get_status(), 'Status should indicate successful request.' );
+        $this->assert( 200, $response->get_status(), 'Status should indicate successful request.' );
 
         $this->assertIsArray( $data, 'Response should be of correct type.' );
@@ -87 +87 @@
         $this->assertArrayHasKey( 'id', $data, 'Response should contain expected fields.' );
 
-        $this->assertEquals( 'wp_navigation', get_post_type( $data['id'] ), '"id" field should represent a post of type "wp_navigation"' );
+        $this->assert( 'wp_navigation', get_post_type( $data['id'] ), '"id" field should represent a post of type "wp_navigation"' );
 
         // Check that only a single Navigation fallback was created.
@@ -106 +106 @@
         $data     = $response->get_data();
 
-        $this->assertEquals( 200, $response->get_status(), 'Status should indicate successful request.' );
+        $this->assert( 200, $response->get_status(), 'Status should indicate successful request.' );
 
         $this->assertArrayHasKey( 'schema', $data, '"schema" key should exist in response.' );
@@ -112 +112 @@
         $schema = $data['schema'];
 
-        $this->assertEquals( 'object', $schema['type'], 'The schema type should match the expected type.' );
+        $this->assert( 'object', $schema['type'], 'The schema type should match the expected type.' );
 
         $this->assertArrayHasKey( 'id', $schema['properties'], 'Schema should have an "id" property.' );
-        $this->assertEquals( 'integer', $schema['properties']['id']['type'], 'Schema "id" property should be an integer.' );
+        $this->assert( 'integer', $schema['properties']['id']['type'], 'Schema "id" property should be an integer.' );
         $this->assertTrue( $schema['properties']['id']['readonly'], 'Schema "id" property should be readonly.' );
     }