Changeset 56844

Timestamp:

10/12/2023 01:24:56 PM (10 months ago)

Author:

audrasjb

Message:

Application Passwords: Prevent the use of some pseudo protocols in application passwords.

Props tykoted, xknown, peterwilsoncc, jorbin, timothyblynjacobs, martinkrcho, paulkevan, dd32, ehtis.
Merges [56837] to the 6.3 branch.

Location:

branches/6.3

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/user.php (modified) (3 diffs)

branches/6.3/src/wp-admin/includes/user.php

@@ -637 +637 @@
  * @since 5.6.0
  * @since 6.2.0 Allow insecure HTTP connections for the local environment.
+
  *
  * @param array   $request {
@@ -650 +651 @@
  */
 function wp_is_authorize_application_password_request_valid( $request, $user ) {
-    $error    = new WP_Error();
-    $is_local = 'local' === wp_get_environment_type();
-
-    if ( ! empty( $request['success_url'] ) ) {
-        $scheme = wp_parse_url( $request['success_url'], PHP_URL_SCHEME );
-
-        if ( 'http' === $scheme && ! $is_local ) {
+    $error = new WP_Error();
+
+    if ( isset( $request['success_url'] ) ) {
+        $validated_success_url = wp_is_authorize_application_redirect_url_valid( $request['success_url'] );
+        if ( is_wp_error( $validated_success_url ) ) {
             $error->add(
-                'invalid_redirect_scheme',
-                __( 'The success URL must be served over a secure connection.' )
+                ,
+                )
             );
         }
     }
 
-    if ( ! empty( $request['reject_url'] ) ) {
-        $scheme = wp_parse_url( $request['reject_url'], PHP_URL_SCHEME );
-
-        if ( 'http' === $scheme && ! $is_local ) {
+    if ( isset( $request['reject_url'] ) ) {
+        $validated_reject_url = wp_is_authorize_application_redirect_url_valid( $request['reject_url'] );
+        if ( is_wp_error( $validated_reject_url ) ) {
             $error->add(
-                'invalid_redirect_scheme',
-                __( 'The rejection URL must be served over a secure connection.' )
+                ,
+                )
             );
         }
@@ -699 +697 @@
     return true;
 }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+