Changeset 56525

Timestamp:

09/06/2023 06:28:59 PM (11 months ago)

Author:

costdev

Message:

Upgrade/Install: Check plugin compatibility during bulk upgrades.

Previously, bulk upgrades did not verify that a plugin package was compatible with the site's WordPress version or the server's PHP version. This could lead to incompatible updates being installed, causing various compatibility issues and errors.

This change implements the following checks:

• If available, the API response's requires and requires_php values are checked for compatibility. This saves time, diskspace, memory and file operations by failing the upgrade before the package is downloaded and unpacked.
• If the API check passes, the downloaded and unpacked package is verified using Plugin_Upgrader::check_package() to ensure a plugin file is present, and the plugin's "RequiresWP" and "RequiresPHP" headers are compatible, if present. This ensures that a mismatch between the API response and the plugin file's headers does not cause an incompatible plugin to be installed.

Props salcode, afragen, mukesh27, iammehedi1, zunaid321, johnbillion, SergeyBiryukov, costdev.
Fixes #59198.

File:

• trunk/src/wp-admin/includes/class-plugin-upgrader.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-plugin-upgrader.php

@@ -275 +275 @@
      * @since 3.7.0 The `$args` parameter was added, making clearing the plugin update cache optional.
      *
+
+
      * @param string[] $plugins Array of paths to plugin files relative to the plugins directory.
      * @param array    $args {
@@ -284 +286 @@
      */
     public function bulk_upgrade( $plugins, $args = array() ) {
+
+
         $defaults    = array(
             'clear_update_cache' => true,
@@ -344 +348 @@
             $this->skin->plugin_active = is_plugin_active( $plugin );
 
-            $result = $this->run(
-                array(
-                    'package'           => $r->package,
-                    'destination'       => WP_PLUGIN_DIR,
-                    'clear_destination' => true,
-                    'clear_working'     => true,
-                    'is_multi'          => true,
-                    'hook_extra'        => array(
-                        'plugin'      => $plugin,
-                        'temp_backup' => array(
-                            'slug' => dirname( $plugin ),
-                            'src'  => WP_PLUGIN_DIR,
-                            'dir'  => 'plugins',
+            if ( isset( $r->requires ) && ! is_wp_version_compatible( $r->requires ) ) {
+                $result = new WP_Error(
+                    'incompatible_wp_required_version',
+                    sprintf(
+                        /* translators: 1: Current WordPress version, 2: WordPress version required by the new plugin version. */
+                        __( 'Your WordPress version is %1$s, however the new plugin version requires %2$s.' ),
+                        $wp_version,
+                        $r->requires
+                    )
+                );
+
+                $this->skin->before( $result );
+                $this->skin->error( $result );
+                $this->skin->after();
+            } elseif ( isset( $r->requires_php ) && ! is_php_version_compatible( $r->requires_php ) ) {
+                $result = new WP_Error(
+                    'incompatible_php_required_version',
+                    sprintf(
+                        /* translators: 1: Current PHP version, 2: PHP version required by the new plugin version. */
+                        __( 'The PHP version on your server is %1$s, however the new plugin version requires %2$s.' ),
+                        PHP_VERSION,
+                        $r->requires_php
+                    )
+                );
+
+                $this->skin->before( $result );
+                $this->skin->error( $result );
+                $this->skin->after();
+            } else {
+                add_filter( 'upgrader_source_selection', array( $this, 'check_package' ) );
+                $result = $this->run(
+                    array(
+                        'package'           => $r->package,
+                        'destination'       => WP_PLUGIN_DIR,
+                        'clear_destination' => true,
+                        'clear_working'     => true,
+                        'is_multi'          => true,
+                        'hook_extra'        => array(
+                            'plugin'      => $plugin,
+                            'temp_backup' => array(
+                                'slug' => dirname( $plugin ),
+                                'src'  => WP_PLUGIN_DIR,
+                                'dir'  => 'plugins',
+                            ),
                         ),
-                    ),
-                )
-            );
+                    )
+                );
+                remove_filter( 'upgrader_source_selection', array( $this, 'check_package' ) );
+            }
 
             $results[ $plugin ] = $result;