Changeset 56271

Timestamp:

07/19/2023 10:33:47 PM (12 months ago)

Author:

antpb

Message:

Media: Adjust PDF upload handling to remove non-opaque alpha channels from previews.

Previously, Imagick uploads of PDF files with non-opaque alpha channels would result in a black background replacing alpha in the generated thumbnail. This patch adds a remove_pdf_alpha_channel() function in the Imagick classes to use a white background instead.

Props gitlost, joemcgill, joedolson, launchinteractive, emirpprime, mwtsn, ceer, maysi, madejackson, 6adminit, costdev, oglekler.
Fixes #39216.

Location:

trunk

Files:

• src/wp-includes/class-wp-image-editor-imagick.php (modified) (2 diffs)
• tests/phpunit/data/images/test-alpha.pdf (added)
• tests/phpunit/tests/image/editorImagick.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-image-editor-imagick.php

@@ -169 +169 @@
             }
 
+
+
+
+
             $this->mime_type = $this->get_mime_type( $this->image->getImageFormat() );
         } catch ( Exception $e ) {
@@ -753 +757 @@
 
     /**
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
      * @since 3.5.0
      * @since 6.0.0 The `$filesize` value was added to the returned array.

trunk/tests/phpunit/tests/image/editorImagick.php

@@ -642 +642 @@
         $this->assertNotWPError( $saved );
     }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }