Changeset 56107

Timestamp:

06/29/2023 07:19:04 AM (13 months ago)

Author:

audrasjb

Message:

Upgrade/Install: Only show errors if there is nothing to update.

Previously, when the do-plugin-upgrade or do-theme-upgrade actions were accessed directly on update-core.php, an error message stating "Select one or
more (plugins|themes) to update" would be shown even if there was nothing to update.

This ensures that the error message only appears when there is something to update.

Props Presskopp, sabernhardt, pbiron, afragen, zunaid321, shuvoaftab, ugyensupport, costdev.
Fixes #57999.

File:

• trunk/src/wp-admin/update-core.php (modified) (1 diff)

trunk/src/wp-admin/update-core.php

@@ -1038 +1038 @@
     <?php
     if ( $upgrade_error ) {
-        echo '<div class="error"><p>';
         if ( 'themes' === $upgrade_error ) {
-            _e( 'Please select one or more themes to update.' );
+            $theme_updates = get_theme_updates();
+            if ( ! empty( $theme_updates ) ) {
+                echo '<div class="error"><p>';
+                _e( 'Please select one or more themes to update.' );
+                echo '</p></div>';
+            }
         } else {
-            _e( 'Please select one or more plugins to update.' );
-        }
-        echo '</p></div>';
+            $plugin_updates = get_plugin_updates();
+            if ( ! empty( $plugin_updates ) ) {
+                echo '<div class="error"><p>';
+                _e( 'Please select one or more plugins to update.' );
+                echo '</p></div>';
+            }
+        }
     }