Changeset 55821

Timestamp:

05/17/2023 06:29:41 PM (15 months ago)

Author:

flixos90

Message:

Media: Introduce wp_get_attachment_image_context filter.

Since WordPress 5.9, a "context" value of "wp_get_attachment_image" has been used in the wp_get_attachment_image() function to provide context to underlying functions where that is relevant, e.g. wp_get_loading_attr_default(). Since that value used to be not customizable, it required a workaround in get_the_post_thumbnail() to avoid calling those functions in wp_get_attachment_image(), which resulted in unnecessary complexity and was prone to errors.

This changeset introduces a wp_get_attachment_image_context filter and leverages it with private filter callback functions that are leveraged by default when get_the_post_thumbnail() is called. This avoids the need for the previous workaround and furthermore provides flexibility for other callers of wp_get_attachment_image() to provide their own contexts.

Props flixos90, costdev, thekt12, westonruter, spacedmonkey.
Fixes #58212.

Location:

trunk

Files:

• src/wp-includes/default-filters.php (modified) (1 diff)
• src/wp-includes/media.php (modified) (2 diffs)
• src/wp-includes/post-thumbnail-template.php (modified) (1 diff)
• tests/phpunit/tests/media.php (modified) (1 diff)
• tests/phpunit/tests/post/thumbnails.php (modified) (1 diff)

trunk/src/wp-includes/default-filters.php

@@ -445 +445 @@
 add_action( 'delete_post', '_wp_delete_customize_changeset_dependent_auto_drafts' );
 
-// Post Thumbnail CSS class filtering.
+// Post Thumbnail  filtering.
 add_action( 'begin_fetch_post_thumbnail_html', '_wp_post_thumbnail_class_filter_add' );
 add_action( 'end_fetch_post_thumbnail_html', '_wp_post_thumbnail_class_filter_remove' );
+
+
 
 // Redirect old slugs.

trunk/src/wp-includes/media.php

@@ -1051 +1051 @@
         );
 
+
+
+
+
+
+
+
+
+
         // Add `loading` attribute.
-        if ( wp_lazy_loading_enabled( 'img', 'wp_get_attachment_image' ) ) {
-            $default_attr['loading'] = wp_get_loading_attr_default( 'wp_get_attachment_image' );
+        if ( wp_lazy_loading_enabled( 'img',  ) ) {
+            $default_attr['loading'] = wp_get_loading_attr_default(  );
         }
 
@@ -2169 +2178 @@
 function _wp_post_thumbnail_class_filter_remove( $attr ) {
     remove_filter( 'wp_get_attachment_image_attributes', '_wp_post_thumbnail_class_filter' );
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }
 

trunk/src/wp-includes/post-thumbnail-template.php

@@ -187 +187 @@
         }
 
-        // Add `loading` attribute.
-        if ( wp_lazy_loading_enabled( 'img', 'the_post_thumbnail' ) ) {
-            // Get the 'loading' attribute value to use as default, taking precedence over the default from
-            // `wp_get_attachment_image()`.
-            $loading = wp_get_loading_attr_default( 'the_post_thumbnail' );
-
-            // Add the default to the given attributes unless they already include a 'loading' directive.
-            if ( empty( $attr ) ) {
-                $attr = array( 'loading' => $loading );
-            } elseif ( is_array( $attr ) && ! array_key_exists( 'loading', $attr ) ) {
-                $attr['loading'] = $loading;
-            } elseif ( is_string( $attr ) && ! preg_match( '/(^|&)loading=/', $attr ) ) {
-                $attr .= '&loading=' . $loading;
-            }
-        }
-
         $html = wp_get_attachment_image( $post_thumbnail_id, $size, false, $attr );
 

trunk/tests/phpunit/tests/media.php

@@ -3965 +3965 @@
 
     /**
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
      * Add threshold to create a `-scaled` output image for testing.
      */

trunk/tests/phpunit/tests/post/thumbnails.php

@@ -451 +451 @@
     }
 
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
     public function filter_post_thumbnail_size( $size, $post_id ) {
         if ( is_array( $this->current_size_filter_data ) && isset( $this->current_size_filter_data[ $post_id ] ) ) {