Changeset 54311

Timestamp:

09/26/2022 02:56:41 PM (22 months ago)

Author:

hellofromTonya

Message:

Editor: Fix spacing property generation in flow layout type.

Fixes a bug of invalid CSS value when applying block spacing to a block as reported in ​Gutenberg issue 44435.

Adds logic to convert preset values (i.e. $gap_value) into valid CSS custom properties for the flow ('default') layout type. See the original fix in ​Gutenberg PR 3324.

Also adds a test dataset that fails before the bugfix and passes after the bugix.

Follow-up to [54274].

Props ndiego, isabel_brison, ramonopoly, andrewserong, hellofromTonya.
See #56467.

Location:

trunk

Files:

• src/wp-includes/block-supports/layout.php (modified) (1 diff)
• tests/phpunit/tests/block-supports/wpGetLayoutStyle.php (modified) (1 diff)

trunk/src/wp-includes/block-supports/layout.php

@@ -57 +57 @@
             }
             if ( null !== $gap_value && ! $should_skip_gap_serialization ) {
+
+
+
+
+
+
+
                 array_push(
                     $layout_styles,

trunk/tests/phpunit/tests/block-supports/wpGetLayoutStyle.php

@@ -249 +249 @@
                 'expected_output' => '.wp-layout{flex-wrap:nowrap;flex-direction:column;align-items:flex-start;}',
             ),
+
+
+
+
+
+
+
+
+
+
+
+
+
+
         );
     }