Changeset 54301

Timestamp:

09/25/2022 02:41:22 AM (22 months ago)

Author:

SergeyBiryukov

Message:

Tests: Delete Link Manager plugin after running REST API plugins controller tests.

After running the multisite PHPUnit test suite, the following files remained, contributing towards a dirty working copy:

tests/phpunit/data/plugins/link-manager/link-manager.php
tests/phpunit/data/plugins/link-manager/readme.txt

These files should be deleted after running the tests.

This commit ensures the link-manager plugin is deleted during test tear down, which was previously done at the beginning of some test methods, but not afterwards.

Follow-up to [48242], [54300].

Props ironprogrammer.
Fixes #56629.

File:

• trunk/tests/phpunit/tests/rest-api/rest-plugins-controller.php (modified) (6 diffs)

trunk/tests/phpunit/tests/rest-api/rest-plugins-controller.php

@@ -87 +87 @@
             $this->rmdir( WP_PLUGIN_DIR . '/test-plugin' );
         }
+
         if ( file_exists( DIR_TESTDATA . '/link-manager.zip' ) ) {
             unlink( DIR_TESTDATA . '/link-manager.zip' );
+
+
+
+
         }
 
@@ -370 +375 @@
      */
     public function test_create_item() {
-        if ( isset( get_plugins()['link-manager/link-manager.php'] ) ) {
-            delete_plugins( array( 'link-manager/link-manager.php' ) );
-        }
-
         wp_set_current_user( self::$super_admin );
         $this->setup_plugin_download();
@@ -390 +391 @@
      */
     public function test_create_item_and_activate() {
-        if ( isset( get_plugins()['link-manager/link-manager.php'] ) ) {
-            delete_plugins( array( 'link-manager/link-manager.php' ) );
-        }
-
         wp_set_current_user( self::$super_admin );
         $this->setup_plugin_download();
@@ -416 +413 @@
      */
     public function test_create_item_and_activate_errors_if_no_permission_to_activate_plugin() {
-        if ( isset( get_plugins()['link-manager/link-manager.php'] ) ) {
-            delete_plugins( array( 'link-manager/link-manager.php' ) );
-        }
-
         wp_set_current_user( self::$super_admin );
         $this->setup_plugin_download();
@@ -442 +435 @@
      */
     public function test_create_item_and_network_activate_rejected_if_not_multisite() {
-        if ( isset( get_plugins()['link-manager/link-manager.php'] ) ) {
-            delete_plugins( array( 'link-manager/link-manager.php' ) );
-        }
-
         wp_set_current_user( self::$super_admin );
         $this->setup_plugin_download();
@@ -466 +455 @@
      */
     public function test_create_item_and_network_activate() {
-        if ( isset( get_plugins()['link-manager/link-manager.php'] ) ) {
-            delete_plugins( array( 'link-manager/link-manager.php' ) );
-        }
-
         wp_set_current_user( self::$super_admin );
         $this->setup_plugin_download();