Changeset 54244

Timestamp:

09/20/2022 04:29:11 AM (23 months ago)

Author:

peterwilsoncc

Message:

Posts, Post types: Prevent get_sample_permalink() modifying the post object.

get_sample_permalink() (ab)uses the $post->filter property to indicate a sample permalink is being generated for the post. This change ensures the property is restored to its original value.

Props herregroen, hellofromTonya, peterwilsoncc, Rahmohn, costdev.
Fixes #54736.

Location:

trunk

Files:

• src/wp-admin/includes/post.php (modified) (2 diffs)
• tests/phpunit/tests/admin/includesPost.php (modified) (1 diff)

trunk/src/wp-admin/includes/post.php

@@ -1400 +1400 @@
     $original_date   = $post->post_date;
     $original_name   = $post->post_name;
+
 
     // Hack: get_permalink() would return plain permalink for drafts, so we will fake that our post is published.
@@ -1444 +1445 @@
     $post->post_date   = $original_date;
     $post->post_name   = $original_name;
-    unset( $post->filter );
+    ;
 
     /**

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -685 +685 @@
         $this->assertSame( home_url() . '/parent-page/%pagename%/', $actual[0] );
         $this->assertSame( 'child-page', $actual[1] );
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
     }