Changeset 46333

Timestamp:

09/26/2019 10:07:05 PM (5 years ago)

Author:

whyisjake

Message:

Options: register_uninstall_hook() causes large amounts of unnecessary option updates.

Prevent extra database read/writes from the the hook.

Props jeichorn, MikeHansenMe, DrewAPicture, Rahe, tha_sun, mikeschroder.
Fixes #31792.

File:

• trunk/src/wp-includes/plugin.php (modified) (1 diff)

trunk/src/wp-includes/plugin.php

@@ -841 +841 @@
      * uninstalling the plugin.
      */
-    $uninstallable_plugins                             = (array) get_option( 'uninstall_plugins' );
-    $uninstallable_plugins[ plugin_basename( $file ) ] = $callback;
-
-    update_option( 'uninstall_plugins', $uninstallable_plugins );
+    $uninstallable_plugins = (array) get_option( 'uninstall_plugins' );
+    $plugin_basename       = plugin_basename( $file );
+    if ( ! isset( $uninstallable_plugins[ $plugin_basename ] ) || $uninstallable_plugins[ $plugin_basename ] !== $callback ) {
+        $uninstallable_plugins[ $plugin_basename ] = $callback;
+        update_option( 'uninstall_plugins', $uninstallable_plugins );
+    }
 }