Changeset 44307

Timestamp:

12/18/2018 10:56:53 PM (6 years ago)

Author:

desrosj

Message:

Twenty Seventeen: Bug Fixes.

• Remove unnecessary ol styles from editor. Twenty Seventeen was designed with bolded numbers for its ordered list styles. This was removed from the theme prior to launch, but it was left in the editor styles, so it needed to be removed there, too.
• To improve accessibility, the cookies content checkbox in the comment form needed some visible indication when it’s in focus.
• Twenty Seventeen’s editor styles contained an Internet Explorer 8 specific fix that stopped images from being scalable in the editor in other browsers. Since the editor no longer supports IE8, this fix can safely be removed.
• Fix the font-family used for Simplified Chinese (zh_CN) in the block editor CSS.

Props mmaumio, edpittol, pratikthink, afercia, audrasjb, mihaivalentin, subrataemfluence, vaishalipanchal, ze3kr, laurelfulford.

Merges [44203-44205] and [44235] into trunk.

Fixes #44775, #44699, #39738, #45408.

Location:

trunk

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentyseventeen/assets/css/editor-blocks.css (modified) (1 diff)
• src/wp-content/themes/twentyseventeen/assets/css/editor-style.css (modified) (3 diffs)
• src/wp-content/themes/twentyseventeen/style.css (modified) (1 diff)

trunk/src/wp-content/themes/twentyseventeen/assets/css/editor-blocks.css

@@ -156 +156 @@
 /* Typography for Chinese Font */
 
-html[lang^="zh-"] .edit-post-visual-editor .editor-block-list__block,
+html[lang^="zh-"] .edit-post-visual-editor .editor-block-list__block {
+    font-family: "PingFang TC", "Helvetica Neue", Helvetica, STHeitiTC-Light, Arial, sans-serif;
+}
+
 html[lang="zh-CN"] .edit-post-visual-editor .editor-block-list__block {
-    font-family: "PingFang TC", "Helvetica Neue", Helvetica, STHeitiTC-Light, Arial, sans-serif;
+    font-family: "PingFang C-Light, Arial, sans-serif;
 }
 

trunk/src/wp-content/themes/twentyseventeen/assets/css/editor-style.css

@@ -233 +233 @@
 }
 
-ol {
-    counter-reset: item;
-}
-
 ol > li {
-    display: block;
     position: relative;
-}
-
-ol > li:before {
-    content: counter(item);
-    counter-increment: item;
-    font-weight: 800;
-    left: -1.5em;
-    position: absolute;
 }
 
@@ -334 +321 @@
 img {
     height: auto; /* Make sure images are scaled correctly. */
-    width: inherit;  /* Make images fill their parent's space. Solves IE8. */
     max-width: 100%; /* Adhere to container width. */
 }
@@ -581 +567 @@
 }
 
-.rtl ol {
-    counter-reset: item;
-}
-
 .rtl ol > li:before {
     left: auto;

trunk/src/wp-content/themes/twentyseventeen/style.css

@@ -981 +981 @@
     height: 3em;
     max-width: 100%;
+
+
+
+
+
 }