WIP: Bug 1887609 - Check if the base directory is accessible in OpenClientDirectory and OpenStorageDirectory. r?#dom-storage-reviewers
Changes PlannedPublicDraft

Authored by jstutte on Mar 28 2024, 5:56 PM.

Details

Reviewers
None
Bugzilla Bug ID
1887609
Summary

This patch alone will most likely move (shutdown) hangs occuring due to
blocking IO on Windows to happen while inside IsBaseDirectoryAccessibleOp::
DoDirectoryWork. Once this is true, we can see how to have better
timeouts.

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default
Lint
No Lint Coverage
SeverityLocationCodeMessage
Warningdom/quota/ActorsParent.cpp:5210bugprone-use-after-moveclang-tidy
Unit
No Test Coverage

Event Timeline

jstutte created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Mar 28 2024, 5:57 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 13 defects in diff 842743:

  • 12 build errors and 1 defect found by clang-tidy
WARNING: Found 1 defect (warning level) that can be dismissed.
IMPORTANT: Found 12 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 842743.

Hmm, locally on Windows this builds for me.

jstutte updated this revision to Diff 873143.
jstutte edited the summary of this revision. (Show Details)

Code analysis found 1 defect in diff 873143:

  • 1 defect found by clang-tidy

1 defect unresolved and 12 defects closed compared to the previous diff 842743.

WARNING: Found 1 defect (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 873143.

Code analysis found 1 defect in diff 873205:

  • 1 defect found by clang-tidy

1 defect closed compared to the previous diff 873143.

WARNING: Found 1 defect (warning level) that can be dismissed.

You can run this analysis locally with:

  • ./mach static-analysis check --outgoing (C/C++)

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 873205.