Differential D152661

Bug 1778014 - Handle perfstats/telemetry case where GC starts after its deadline has passed
ClosedPublic
Actions

Authored by sfink on Jul 25 2022, 4:11 PM.

Details

Reviewers
smaug
Commits
rMOZILLACENTRAL29f86bbb3299: Bug 1778014 - Handle perfstats/telemetry case where GC starts after its…
Bugzilla Bug ID
1778014

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable
Build Status
Buildable 451245
Build 546820: arc lint + arc unit

Event Timeline

sfink created this revision.Jul 25 2022, 4:11 PM

Handle perfstats/telemetry case where GC starts after its deadline has passed

Herald added a project: secure-revision. · View Herald TranscriptJul 25 2022, 4:11 PM
Harbormaster completed remote builds in B446304: Diff 606189.Jul 25 2022, 4:11 PM
phab-bot published this revision for review.Jul 25 2022, 4:11 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
reviewbot added a subscriber: reviewbot.Jul 25 2022, 4:29 PM

The analysis task source-test-mozlint-mingw-cap failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

smaug accepted this revision.Aug 2 2022, 12:21 PM
smaug added a project: testing-exception-other (Please leave a comment explaining why) .

This changes telemetry only in a very edge case.

dom/base/CCGCScheduler.cpp
258

I think >= is fine here, but perhaps > would in principle make more sense.

This revision is now accepted and ready to land.Aug 2 2022, 12:21 PM
sfink updated this revision to Diff 611909.Aug 8 2022, 5:27 PM

Updated revision.

Harbormaster completed remote builds in B451026: Diff 611909.Aug 8 2022, 5:27 PM
Closed by commit rMOZILLACENTRAL29f86bbb3299: Bug 1778014 - Handle perfstats/telemetry case where GC starts after its… (authored by Steve Fink <sfink@mozilla.com>). · Explain WhyAug 8 2022, 5:35 PM
This revision was automatically updated to reflect the committed changes.
Steve Fink <sfink@mozilla.com> added a commit: rMOZILLACENTRAL29f86bbb3299: Bug 1778014 - Handle perfstats/telemetry case where GC starts after its….

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
dom/
base/
9 lines97%
Loading...

Diff 611920

View Options

dom/base/CCGCScheduler.cpp

Loading...
Privacy · Cookies · Legal