Differential D50901
Bug 1587162 - Fix UBSAN complaints about pref callbacks. r=erahm ClosedPublic Authored by • njn on Oct 29 2019, 5:59 AM.
Details
Summary Lots of these callbacks have a non-void* final parameter, which UBSAN This requires undoing the machinery added in the first two commits of bug
1473631: TypePrefChangeFunc and PREF_CHANGE_METHOD. The resulting code is
Diff Detail
Event TimelineHarbormaster completed remote builds in B128841: Diff 183009.Oct 29 2019, 5:59 AM2019-10-29 05:59:48 (UTC+0) Herald added subscribers: mayhemer, emilio. · View Herald TranscriptOct 29 2019, 5:59 AM2019-10-29 05:59:51 (UTC+0) This revision is now accepted and ready to land.Oct 31 2019, 11:25 PM2019-10-31 23:25:23 (UTC+0) • njn retitled this revision from Bug 1587176 - Fix UBSAN complaints about pref callbacks. r=erahm to Bug 1587162 - Fix UBSAN complaints about pref callbacks. r=erahm.Nov 1 2019, 2:57 AM2019-11-01 02:57:12 (UTC+0) Harbormaster completed remote builds in B130185: Diff 184948.Nov 1 2019, 2:57 AM2019-11-01 02:57:14 (UTC+0) Harbormaster completed remote builds in B130194: Diff 184964.Nov 1 2019, 3:41 AM2019-11-01 03:41:45 (UTC+0) Closed by commit rMOZILLACENTRAL30ee2029152c: Bug 1587162 - Fix UBSAN complaints about pref callbacks. r=erahm (authored by • njn). · Explain WhyNov 1 2019, 9:00 AM2019-11-01 09:00:31 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 185071 |